Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29769 )
Change subject: mb/google/fizz/variants/karma: Enable touchscreen wakeup ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29769/1/src/mainboard/google/fizz/variants/k... File src/mainboard/google/fizz/variants/karma/gpio.c:
https://review.coreboot.org/#/c/29769/1/src/mainboard/google/fizz/variants/k... PS1, Line 54: PAD_CFG_GPO(GPP_B4, 1, DEEP), /* PCH_TS_EN */ I haven't looked at the schematics or the part data sheet. How does this enable work? Does it need to be set always or just before entering suspend? Does it need to be disabled when entering deeper states like S5? You can email me the datasheet if you want.
-
Furquan Shaikh (Code Review)