Attention is currently required from: Idwer Vollering, Stefan Reinauer, Michael Niewöhner, Ron Minnich. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58382 )
Change subject: Documentation: Define which languages are permitted. ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File Documentation/contributing/coding_style.md:
https://review.coreboot.org/c/coreboot/+/58382/comment/8bb19beb_14faeb73 PS1, Line 23: * Python, which already isn't listed above but deserves a special mention : here because it demonstrated the need for this list in the first place. :
Well, regarding Python, also check out the discussion on CB:56410. […]
I agree with Michael. This is wrong. People have different flavours and so they know different programming languages. And not only that, they all have different use cases. I don't use one language for everything because every of them has advantages and disadvantages.
I also don't like every language, but I don't hate any language so much so that I wouldn't use a specific tool. As long as the tool works and does what it is expected to do, I just don't care. I just use it because it exists and it makes my life easier. Everyone is free to not using it and to do their own thing.
Also, as long as there is a maintainer for the tool, I don't see a problem there. This can be easily managed with the MAINTAINERS file. If the tool has issues (or doesn't work anymore, whatever) and the maintainer doesn't respond, we can drop it. People still can write their own tool then. But until this specific point, the tool might have been helpful. I mean, at least someone cared, right?
I remember I once had an issue compiling the intelp2m tool, because some defaults of the Go compiler changed, but its error message was very unclear and I wasn't able to find a solution. Not even anything related. Also people from the coreboot community didn't know a fix in the first moment. The fix was this commit ee85d00ed6693d. Nothing is perfect and everything can break, no matter which language it is.
I think this will just reduce the contributions of useful tools. Who wants to develop a coreboot related tool on Github or Gitlab when everything happens here? Not even thinking of that you can't see the complete message history on Github when you are not logged in. Or their user interface for reviews. This is garbage. I really like using Gerrit because it works so much better than anything else and it makes much more fun.
However, I don't see any reason why we should reject contributions, which are not fulfilling these requirements.
-
Felix Singer (Code Review)