Attention is currently required from: Johannes Hahn, Mario Scheithauer, Werner Zeh.
Uwe Poeche has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86423?usp=email )
Change subject: mb/siemens/fa_ehl/variants/fa_ehl/spd: Add Nanya remove Micron SPD data
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/siemens/fa_ehl/variants/fa_ehl/spd/Nanya_NT6AP512T32BV-J1I.spd.hex:
https://review.coreboot.org/c/coreboot/+/86423/comment/97d06b7c_fb7d326d?usp... :
PS2, Line 1: 23 11 11 0E 15 21 90 08 00 40 00 00 02 22 00 00
Just a formal thing from my point of view: exchange files would be more transparent via "git rm old" and "git add new". Also *.hex in file name does not suggest that it is an ascii format. But I think the format is fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86423?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icbfb3a51fcb7c09bad9b70861fa58f5c957ce1ae
Gerrit-Change-Number: 86423
Gerrit-PatchSet: 2
Gerrit-Owner: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 19 Feb 2025 15:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes