Attention is currently required from: Nico Huber, Evgeny Zinoviev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 )
Change subject: cpu/intel/sandybridge: Add `hyper_threading` option
......................................................................
Patch Set 16: Code-Review+1
(1 comment)
File src/cpu/intel/model_206ax/bootblock.c:
https://review.coreboot.org/c/coreboot/+/29669/comment/4ddca9ba_0e900c7a
PS2, Line 132: outb(0x2, 0xcf9);
: outb(0x6, 0xcf9);
: halt();
system_reset() writes 0x2 then 0x6, we don't need it i think?
It should be clearer than writing to I/O ports
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b73e32ff5af8ea64a47e8aa706e27648aaf0993
Gerrit-Change-Number: 29669
Gerrit-PatchSet: 16
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Fri, 18 Nov 2022 12:04:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.io
Gerrit-MessageType: comment