Attention is currently required from: Nico Huber, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Michael Niewöhner, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62624 )
Change subject: soc/intel/tgl: add device UART #3 to chipset devicetree
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62624/comment/dceaae5f_9ad5eb8d
PS2, Line 9: Reference: Intel doc# 631119-007
The only reference to UART controller #3 I could find in this document is in `Table 6. PCH-UP3/UP4 Device and Revision ID Table`. The rest of the document says/implies there are only 3 UART controllers (0, 1, 2).
Do you have other sources that confirm the existence of UART controller #3? Are there any pads for this UART #3?
Patchset:
PS2:
I'm not convinced that this device actually exists. My -1 is because uart.c needs to be updated accordingly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3abccf65d59278b38835cdfda9e54991d6edaacf
Gerrit-Change-Number: 62624
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 11:52:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment