[M] Change in coreboot[master]: soc/intel/alderlake: Check MANUF_LOCK when logging manufacturing mode
Attention is currently required from: Tarun Tuli, Michał Żygowski, Kangheui Won, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69324 )
Change subject: soc/intel/alderlake: Check MANUF_LOCK when logging manufacturing mode ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69324/comment/e4368829_8db1167a PS1, Line 22: On an anahera which has gone through EOM:
Add a blank above?
Done
https://review.coreboot.org/c/coreboot/+/69324/comment/875292ef_9c07dc74 PS1, Line 24:
Before the patch, firmware used to check only 2 conditions (#1 and #2 as mentioned in the commit mes […]
I think Paul meant what was the output before the patch. Added.
File src/soc/intel/alderlake/me.c:
https://review.coreboot.org/c/coreboot/+/69324/comment/91e16c96_d243649f PS1, Line 141: hfsts1.fields.mfg_mode
What I am trying to say is that when somebody reflashes the descriptor externally or do not decide t […]
I see your point that it's a bit arbitrary exactly which conditions the Manufacturing Mode log should represent.
I think it makes most sense to follow the definition in Intel documentation, which for ADL clearly says a device should be considered in production mode only if all three criteria are met, and customers should use the individual indicators to determine exactly which steps have been done.
In the latest patchset I've added logs for each of individual criteria to make it easier to tell why Manufacturing Mode is set or not.
-
Reka Norman (Code Review)