Change in coreboot[master]: src: (part 2) Add missing 'include <commonlib/helpers.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37418 )

Change subject: src: (part 2) Add missing 'include <commonlib/helpers.h>'
......................................................................

src: (part 2) Add missing 'include <commonlib/helpers.h>'

'offsetof' and DIV_ROUND_CLOSEST needs <commonlib/helpers.h>.

Change-Id: Ida2bca01151fc4f392ecdd29cc9bc31ec52d9cc0
Signed-off-by: Elyes HAOUAS 
---
M src/console/printk.c
M src/cpu/ti/am335x/header.c
M src/drivers/elog/boot_count.c
M src/drivers/elog/elog.c
M src/drivers/intel/gma/opregion.c
M src/lib/timestamp.c
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/scaleway/tagada/bmcinfo.c
M src/soc/intel/quark/include/soc/i2c.h
M src/soc/mediatek/mt8183/emi.c
M src/soc/nvidia/tegra/gpio.c
M src/soc/nvidia/tegra210/include/soc/tegra_dsi.h
M src/soc/rockchip/common/spi.c
13 files changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37418/1

diff --git a/src/console/printk.c b/src/console/printk.c
index a08dd2f..5eb25a0 100644
--- a/src/console/printk.c
+++ b/src/console/printk.c
@@ -13,6 +13,7 @@
  * blatantly copied from linux/kernel/printk.c
  */

+#include <commonlib/helpers.h>
 #include <console/cbmem_console.h>
 #include <console/console.h>
 #include <console/streams.h>
diff --git a/src/cpu/ti/am335x/header.c b/src/cpu/ti/am335x/header.c
index bef1e56..99ff652 100644
--- a/src/cpu/ti/am335x/header.c
+++ b/src/cpu/ti/am335x/header.c
@@ -12,6 +12,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <symbols.h>
diff --git a/src/drivers/elog/boot_count.c b/src/drivers/elog/boot_count.c
index a6efb01..133fc99 100644
--- a/src/drivers/elog/boot_count.c
+++ b/src/drivers/elog/boot_count.c
@@ -11,6 +11,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <ip_checksum.h>
 #include <pc80/mc146818rtc.h>
diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index 768ea28..b749eac 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -16,6 +16,7 @@
 #endif
 #include <bootstate.h>
 #include <cbmem.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #if CONFIG(ARCH_X86)
 #include <pc80/mc146818rtc.h>
diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c
index 56449d0..32d0c27 100644
--- a/src/drivers/intel/gma/opregion.c
+++ b/src/drivers/intel/gma/opregion.c
@@ -16,6 +16,7 @@
 #include <types.h>
 #include <string.h>
 #include <cbfs.h>
+#include <commonlib/helpers.h>
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c
index 7c7210c..e00c882 100644
--- a/src/lib/timestamp.c
+++ b/src/lib/timestamp.c
@@ -17,6 +17,7 @@
 #include <assert.h>
 #include <stddef.h>
 #include <stdint.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <cbmem.h>
 #include <symbols.h>
diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
index 50123f9..e108f91 100644
--- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
+++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c
@@ -15,6 +15,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <smbios.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <arch/io.h>
 #include <arch/acpi.h>
diff --git a/src/mainboard/scaleway/tagada/bmcinfo.c b/src/mainboard/scaleway/tagada/bmcinfo.c
index 93b4539..d22785c 100644
--- a/src/mainboard/scaleway/tagada/bmcinfo.c
+++ b/src/mainboard/scaleway/tagada/bmcinfo.c
@@ -16,6 +16,7 @@

#include <stdint.h>
 #include <stdlib.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <console/uart.h>

diff --git a/src/soc/intel/quark/include/soc/i2c.h b/src/soc/intel/quark/include/soc/i2c.h
index f3c585f..9abe402 100644
--- a/src/soc/intel/quark/include/soc/i2c.h
+++ b/src/soc/intel/quark/include/soc/i2c.h
@@ -16,6 +16,7 @@
 #ifndef _QUARK_I2C_H_
 #define _QUARK_I2C_H_

+#include <commonlib/helpers.h>
 #include <stdint.h>

typedef volatile struct _I2C_REGS {
diff --git a/src/soc/mediatek/mt8183/emi.c b/src/soc/mediatek/mt8183/emi.c
index 7cd631c..15d7fb7 100644
--- a/src/soc/mediatek/mt8183/emi.c
+++ b/src/soc/mediatek/mt8183/emi.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <soc/dramc_param.h>
 #include <soc/dramc_pi_api.h>
diff --git a/src/soc/nvidia/tegra/gpio.c b/src/soc/nvidia/tegra/gpio.c
index 6800c5d..2e4bf02 100644
--- a/src/soc/nvidia/tegra/gpio.c
+++ b/src/soc/nvidia/tegra/gpio.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <gpio.h>
 #include <soc/addressmap.h>
diff --git a/src/soc/nvidia/tegra210/include/soc/tegra_dsi.h b/src/soc/nvidia/tegra210/include/soc/tegra_dsi.h
index 00bf659..b55ac78 100644
--- a/src/soc/nvidia/tegra210/include/soc/tegra_dsi.h
+++ b/src/soc/nvidia/tegra210/include/soc/tegra_dsi.h
@@ -15,6 +15,7 @@
 #ifndef __TEGRA_DSI_H__
 #define __TEGRA_DSI_H__

+#include <commonlib/helpers.h>
 #include <device/mmio.h>

#define DSI_INCR_SYNCPT			0x00
diff --git a/src/soc/rockchip/common/spi.c b/src/soc/rockchip/common/spi.c
index 0307e24..69d6ce0 100644
--- a/src/soc/rockchip/common/spi.c
+++ b/src/soc/rockchip/common/spi.c
@@ -15,6 +15,7 @@

#include <device/mmio.h>
 #include <assert.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <delay.h>
 #include <endian.h>

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37418

to look at the new patch set (#2).

Change subject: src: (part 2) Add missing 'include <commonlib/helpers.h>'
......................................................................

src: (part 2) Add missing 'include <commonlib/helpers.h>'

'offsetof', MIN() and DIV_ROUND_CLOSEST() needs <commonlib/helpers.h>.

Change-Id: Ida2bca01151fc4f392ecdd29cc9bc31ec52d9cc0
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/mpspec.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/storage.c
M src/commonlib/storage/storage_write.c
M src/console/printk.c
M src/cpu/ti/am335x/header.c
M src/cpu/x86/mtrr/xip_cache.c
M src/device/dram/ddr2.c
M src/device/dram/ddr3.c
M src/device/dram/ddr4.c
M src/device/mmio.c
M src/drivers/elog/boot_count.c
M src/drivers/elog/elog.c
M src/drivers/i2c/ck505/ck505.c
M src/drivers/intel/gma/opregion.c
M src/drivers/intel/gma/vbt.c
M src/drivers/pc80/rtc/mc146818rtc_boot.c
M src/drivers/spi/tpm/tpm.c
M src/drivers/vpd/vpd.c
M src/ec/lenovo/h8/h8.c
M src/lib/device_tree.c
M src/lib/fit.c
M src/lib/fmap.c
M src/lib/hexdump.c
M src/lib/nhlt.c
M src/lib/ramdetect.c
M src/lib/timestamp.c
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/lenovo/s230u/mainboard.c
M src/mainboard/scaleway/tagada/bmcinfo.c
M src/northbridge/intel/gm45/igd.c
M src/northbridge/intel/i945/raminit.c
M src/northbridge/intel/pineview/raminit.c
M src/northbridge/intel/sandybridge/raminit_common.c
M src/security/tpm/tspi/log.c
M src/security/tpm/tspi/tspi.c
M src/security/vboot/ec_sync.c
M src/soc/intel/broadwell/romstage/raminit.c
M src/soc/intel/common/block/lpc/lpc_lib.c
M src/soc/intel/quark/include/soc/i2c.h
M src/soc/mediatek/common/dsi.c
M src/soc/mediatek/common/spi.c
M src/soc/mediatek/mt8173/flash_controller.c
M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c
M src/soc/mediatek/mt8183/emi.c
M src/soc/nvidia/tegra/gpio.c
M src/soc/nvidia/tegra/i2c.c
M src/soc/nvidia/tegra124/dp.c
M src/soc/nvidia/tegra124/sdram.c
M src/soc/nvidia/tegra124/spi.c
M src/soc/nvidia/tegra210/dp.c
M src/soc/nvidia/tegra210/include/soc/tegra_dsi.h
M src/soc/nvidia/tegra210/spi.c
M src/soc/qualcomm/ipq806x/spi.c
M src/soc/qualcomm/sdm845/qspi.c
M src/soc/rockchip/common/edp.c
M src/soc/rockchip/common/i2c.c
M src/soc/rockchip/common/spi.c
M src/soc/rockchip/rk3399/sdram.c
M src/soc/samsung/exynos5250/clock.c
M src/soc/samsung/exynos5250/spi.c
M src/soc/samsung/exynos5420/clock.c
M src/soc/samsung/exynos5420/spi.c
M src/southbridge/intel/common/smbus.c
64 files changed, 64 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37418/2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37418 )

Change subject: src: (part 2) Add missing 'include <commonlib/helpers.h>'
......................................................................

Abandoned