Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31070
Change subject: soc/intel/denverton_ns: Remove soc_reset_tco_status() ......................................................................
soc/intel/denverton_ns: Remove soc_reset_tco_status()
Before commit ab1227226eb landed, that function was obsoleted and now the compiler complains.
Change-Id: I1a612e59c81f742dd4ea1a9c02842ddf17341eb0 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/soc/intel/denverton_ns/pmutil.c 1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/31070/1
diff --git a/src/soc/intel/denverton_ns/pmutil.c b/src/soc/intel/denverton_ns/pmutil.c index 344f8b9..e75feb1 100644 --- a/src/soc/intel/denverton_ns/pmutil.c +++ b/src/soc/intel/denverton_ns/pmutil.c @@ -69,16 +69,6 @@ return tco_sts_bits; }
-uint32_t soc_reset_tco_status(void) -{ - uint16_t tcobase = get_tcobase(); - uint32_t tco_sts = inl((uint16_t)(tcobase + TCO1_STS)); - uint32_t tco_en = inl((uint16_t)(tcobase + TCO1_CNT)); - - outl(tco_sts, (uint16_t)(tcobase + TCO1_STS)); - return tco_sts & tco_en; -} - const char *const *soc_std_gpe_sts_array(size_t *a) { static const char *const gpe_sts_bits[] = {
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31070 )
Change subject: soc/intel/denverton_ns: Remove soc_reset_tco_status() ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31070/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31070/1//COMMIT_MSG@9 PS1, Line 9: commit ab1227226eb Please add the commit message summary after the hash: soc/intel/denverton_ns: Rewrite pmutil using pmclib
Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31070 )
Change subject: soc/intel/denverton_ns: Remove soc_reset_tco_status() ......................................................................
Abandoned
doing a revert instead: https://review.coreboot.org/c/coreboot/+/31071