Change in coreboot[master]: mb/google/brya/{}: Add SBU orientation property for Type C Mux
Attention is currently required from: Subrata Banik, Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak, Prashant Malani, Nick Vaccaro, Rajat Jain. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61622 )
Change subject: mb/google/brya/{}: Add SBU orientation property for Type C Mux ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61622/comment/c7a8f19d_cd85f0d0 PS5, Line 7: /{}
What do the brackets denote?
all the variants of brya.
https://review.coreboot.org/c/coreboot/+/61622/comment/70494f52_d38169df PS5, Line 8:
Please describe the current problem.
This setting is needed for the type C display to work in both the orientation
File src/mainboard/google/brya/variants/felwinter/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61622/comment/a488d7b3_12962a03 PS6, Line 328: # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
Sorry for the late comment here: Why does the other port not need this? Is only this port the one wh […]
@Deepti, can you pls comment here?
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61622/comment/b08c4ef6_67b6c40d PS6, Line 450: # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORM
Does the other port not use a retimer?
@Deepti, pls comment here.
-
Meera Ravindranath (Code Review)