Attention is currently required from: Nico Huber, Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55318 )
Change subject: drivers/intel/gma: Restructure IGD opregion init code
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/55318/comment/63858a0c_225f4aed
PS2, Line 321: we need
It's requirement of OPREGION 2.1 spec as it expects extended VBT to sit at 8 KiB offset. […]
Is the OpRegion 2.1 specification publicly available?
https://review.coreboot.org/c/coreboot/+/55318/comment/493adddf_4418d0d8
PS2, Line 327: opregion = cbmem_add(CBMEM_ID_IGD_OPREGION, opregion_size);
sure...Let me split the patch into 2.
Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I479d57cd326567192a3cd1969f8125ffe1934399
Gerrit-Change-Number: 55318
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 09 Jun 2021 12:19:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment