Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39427 )
Change subject: mb/ocp/tiogapass: use common GPIO config
......................................................................
Patch Set 38: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39427/38/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/39427/38/src/mainboard/ocp/tiogapas...
PS38, Line 20: /* configure Lewisburg PCH GPIO pads */
Any reason to do this in ramstage now? Does FSP-M expect GPIOs to be configured before it runs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I818d040fa33f3e7b94b73c9bbbafca5df424616d
Gerrit-Change-Number: 39427
Gerrit-PatchSet: 38
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Apr 2020 09:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment