Attention is currently required from: Philipp Hug, Patrick Georgi, Jakub Czapiga, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64737 )
Change subject: commonlib: Clean up compiler.h ......................................................................
Patch Set 3:
(8 comments)
File src/commonlib/bsd/include/commonlib/bsd/compiler.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/79a9a846_ac58f55e PS3, Line 8: #define __packed __attribute__((__gcc_struct__, __packed__)) Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/a8f4ef9d_861eed5b PS3, Line 10: #define __packed __attribute__((__packed__)) Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/dd1f593a_139af07f PS3, Line 15: #define __aligned(x) __attribute__((__aligned__(x))) Prefer __aligned(x) over __attribute__((__aligned__(x)))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/7b86e152_d08af777 PS3, Line 19: #define __unused __attribute__((__unused__)) __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/8c854678_3c1b73c4 PS3, Line 27: #define __weak __attribute__((__weak__)) Prefer __weak over __attribute__((__weak__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/da4bbd3f_b5b0a49c PS3, Line 31: #define __noreturn __attribute__((__noreturn__)) Prefer __noreturn over __attribute__((__noreturn__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/82815be4_faf5a968 PS3, Line 35: #define __always_inline inline __attribute__((__always_inline__)) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150414): https://review.coreboot.org/c/coreboot/+/64737/comment/b3c8cce9_f9c190b4 PS3, Line 35: #define __always_inline inline __attribute__((__always_inline__)) Prefer __always_inline over __attribute__((__always_inline__))
-
build bot (Jenkins) (Code Review)