Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Utkarsh Verma.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: arch/x86/smbios: Avoid buffer overflows ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: No idea what Coverity is complaining about, but these changes don't really make sense...
Will have a second look tomorrow after resting.
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74128/comment/4b6dad88_96e413f6 PS4, Line 148: char string_buffer[15]; How exactly does reducing the buffer size avoid buffer overflows? It would only seem to make them more likely...
https://review.coreboot.org/c/coreboot/+/74128/comment/29f27f55_5c9ca798 PS4, Line 552: static unsigned short cnt = 0; Why change the type?
-
Angel Pons (Code Review)