Change in ...coreboot[master]: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )

Change subject: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31133/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31133/1//COMMIT_MSG@17 
PS1, Line 17: added
> Present tense (imperative mood): add

Done

https://review.coreboot.org/#/c/31133/1/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/31133/1/src/soc/intel/cannonlake/chip.h@40 
PS1, Line 40: #define IS_CFL_OR_WHL(x, y) (IS_ENABLED(x) || IS_ENABLED(y))
> IMHO, there's no need to pass parameters to this macro. It could be something like: […]

Done