Attention is currently required from: Martin Roth, zanxi chen, Paul Menzel, Weimin Wu, Andy Yeh, Karthik Ramasubramanian.
Andy Yeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50995 )
Change subject: mb/google/dedede/var/storo: Add camera support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Even if camera EEPROM is going to be provisioned later, I would like SSFC in CBI to be provisioned n […]
In that case, these CLs (could be referred) need be landed.
https://review.coreboot.org/c/coreboot/+/45172
https://review.coreboot.org/c/coreboot/+/50261 (Private now - can you access?)
https://review.coreboot.org/c/coreboot/+/45445
CBI could set as in the end of 32bit FW_CONFIG.
1. WFC - 3 bit (0: none-MIPI; 1: Kingcome 8MP; 2: TBD
2. UFC - 2 bit (0: none-MIPI) --> 0 since UFC is USB.
However, we should take Maglia as higher priority (not clarified yet). And leverage the same approach to Storo by copying exactly as its schedule is later.
Karthik, Henry, What do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98d5708d1955406c2e46db972903057bb3d12dcc
Gerrit-Change-Number: 50995
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Andy Yeh
andy.yeh@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 00:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun
henrysun@google.com
Comment-In-Reply-To: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Andy Yeh
andy.yeh@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment