Attention is currently required from: Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie, Brandon Breitenstein.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51195 )
Change subject: mb/google/volteer: Configure tcss port information for early tcss init
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51195/comment/5725b378_a9b2217e
PS1, Line 182: mux_info
My only thing with this is how would we define MAX_TYPE_C_PORTS? for TGL that is 4 but we are only u […]
I think you can still set the MAX_TYPE_C_PORTS to 4 and return num_ports based on what get_connector_config returns. It is not too bad if you restrict MAX_TYPE_C_PORTS in volteer to 2 since all volteer boards will just use upto a maximum of 2 type-C ports. It wouldn't impact any other TGL-based board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59e5c5a7d2ab5ef5293abe6c59c3a585b25f7b75
Gerrit-Change-Number: 51195
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Duncan Laurie
dlaurie@gmail.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 23:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment