Attention is currently required from: Felix Singer, Krystian Hebel, Michał Kopeć, Michał Żygowski.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69825?usp=email )
Change subject: mb/msi/ms7d25: Configure ASPM and Clock PM based on Kconfig ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69825/comment/c4bcedef_329783f4 : PS3, Line 11: to achieve more deterministic and higher performance of PCIe devices
Acknowledged
Thank you for the explanation.
Commit Message:
https://review.coreboot.org/c/coreboot/+/69825/comment/3c2bd085_f868fc15 : PS4, Line 9: Kconfig If you do another round, maybe mention the two options:
``` config PCIEXP_ASPM prompt "Enable PCIe ASPM" bool default n help Detect and enable ASPM (Active State Power Management) on PCIe links.
config PCIEXP_CLK_PM prompt "Enable PCIe Clock Power Management" bool default n help Detect and enable Clock Power Management on PCIe. ```
Patchset:
PS4: Ok, I guess I was confused that Kconfig options were not honored from the beginning. Is that a design problem in coreboot, or was it just unconditionally enabled, because the first devices were “devices with batteries”, so the code was optimized for powersaving?