Change in coreboot[master]: commonlib/bsd/helpers: Remove redundancy with libpayload defines - coreboot-gerrit

30 Mar 2022


      Attention is currently required from: Jakub Czapiga.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62921 )
Change subject: commonlib/bsd/helpers: Remove redundancy with libpayload defines
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/62921/comment/c8627d13_2fd426e6 
PS5, Line 130: #ifndef STRINGIFY
nit: it would be great if we could get rid of this #ifndef as well, having multiple definition sites is generally not a good pattern. but doesn't need to be in this patch.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62921
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3263b2aa7657759207bf6ffda750d839e741f99c
Gerrit-Change-Number: 62921
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 22:06:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment