Change in coreboot[master]: drivers/intel/fsp2_0: Allow coreboot to control FSP serial redirection
Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Arthur Heymans, Lean Sheng Tan, Andrey Petrov. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63166 )
Change subject: drivers/intel/fsp2_0: Allow coreboot to control FSP serial redirection ......................................................................
Patch Set 1:
(11 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63166/comment/b38aec54_74721918 PS1, Line 9: coreboot has implemented native FSP debug handler with commit hash : 3ba6f8cdf (drivers/intel/fsp2_0: Add native implementation for FSP : Debug Handler). Maybe:
Commit 3ba6f8cdf (drivers/intel/fsp2_0: Add native implementation for FSP Debug Handler) implements a native FSP debug handler.
https://review.coreboot.org/c/coreboot/+/63166/comment/1ad83bb0_16728fd6 PS1, Line 12: However, coreboot still can't control when to redirect FSP debug Please add a blank line above to separate paragraphs.
https://review.coreboot.org/c/coreboot/+/63166/comment/01ebf5f0_665674b8 PS1, Line 12: One space.
https://review.coreboot.org/c/coreboot/+/63166/comment/0cbe7a4a_0f728b89 PS1, Line 15: wish wishes
https://review.coreboot.org/c/coreboot/+/63166/comment/01b51fe2_e0c9e18c PS1, Line 15: to see FSP debug log : with all the coreboot serial image Please rephrase, as I do not understand it.
https://review.coreboot.org/c/coreboot/+/63166/comment/a3b72a23_a1044f5e PS1, Line 19: an a
https://review.coreboot.org/c/coreboot/+/63166/comment/35a7391d_d208b88f PS1, Line 21: incase in case
https://review.coreboot.org/c/coreboot/+/63166/comment/a32cea0e_6266af57 PS1, Line 26: Non-serial coreboot image Maybe mention console, or rephrase.
https://review.coreboot.org/c/coreboot/+/63166/comment/05f47460_079c58e4 PS1, Line 55: Redrix google/redrix
https://review.coreboot.org/c/coreboot/+/63166/comment/dd28155b_c0e929b6 PS1, Line 55: #1- #3 #1–#3 or #1--#3
https://review.coreboot.org/c/coreboot/+/63166/comment/540e6f34_75caadbe PS1, Line 57: Can FSP messages be put into CBMEM console or is only serial supported?
-
Paul Menzel (Code Review)