Attention is currently required from: Moritz Fischer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50853 )
Change subject: soc/rockchip/rk3399/sdram: Appease clang-format ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
overall, I still see these changes as an improvement. Not perfect, definitely better. […]
clang-format doesn't support the braces-switcheroo at this time. clang-tidy does but is a pain to setup. Braces are now tracked in https://ticket.coreboot.org/issues/294 (and the entire clang-format topic in https://ticket.coreboot.org/issues/290)
File src/soc/rockchip/rk3399/sdram.c:
https://review.coreboot.org/c/coreboot/+/50853/comment/018f3f05_1f6cdaa7 PS1, Line 54:
Not really sure I agree with most of these changes tbh, I feel some of them really decrease readabil […]
The alignment issue will be fixed by https://review.coreboot.org/c/coreboot/+/50546, "AlignConsecutiveMacros: true" in particular.
-
Patrick Georgi (Code Review)