Attention is currently required from: Arthur Heymans, Martin L Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76505?usp=email )
Change subject: soc/amd/genoa: Enable PM and cf9 IO early
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
File src/soc/amd/genoa/early_fch.c:
https://review.coreboot.org/c/coreboot/+/76505/comment/4b7efc23_aba2183e :
PS2, Line 16: enable_acpimmio_decode_pm04();
The Genoa PPR claims that PMIO can still be accessed through the CD6/CD7 mechanism, so I added the K […]
i read the ppr like that this won't work, so i wouldn't select SOC_AMD_COMMON_BLOCK_ACPIMMIO_PM_IO_ACCESS and remove the enable_acpimmio_decode_pm04 call. have a look at phoenix; the difference will be though that while on phoenix it's not available, on genoa it's just not functional
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05990c2aca40d9cf47a9ebdfd269b80b8f60e300
Gerrit-Change-Number: 76505
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 29 Sep 2023 18:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment