Change in coreboot[master]: mb/clevo/cml-u: move gpio early init to bootblock_mainboard_early_init - coreboot-gerrit

21 Dec 2020


      Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48801 )
Change subject: mb/clevo/cml-u: move gpio early init to bootblock_mainboard_early_init
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG@10 
PS2, Line 10: after gpio configuration in
            : common code got dropped.
...
Why does this depend on the common GPIO code changes?
Cometlake is not even handled in your changes. So I think you can remove that and rebase on CB:48328.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I619f7d0e15adae284b606dd20c3c1f04f3eafd7b
Gerrit-Change-Number: 48801
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 21 Dec 2020 19:11:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To:  Felix Singer felixsinger@posteo.net
Gerrit-MessageType: comment