Attention is currently required from: Felix Singer, Tarun Tuli, Subrata Banik, Dinesh Gehlot, Kapil Porwal, Angel Pons, Arthur Heymans, Werner Zeh.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73128 )
Change subject: soc/intel/cmn: Include ME specification configuration at common
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/73128/comment/ac4135b9_c0becf4c
PS1, Line 259: if SOC_INTEL_CSE_HAVE_SPEC_SUPPORT
Put this line above SOC_INTEL_COMMON_BLOCK_ME_SPEC_11. Than you can also remove the depends of all SOC_INTEL_COMMON_BLOCK_ME_SPEC_x
https://review.coreboot.org/c/coreboot/+/73128/comment/bc4435d8_b82543de
PS1, Line 261: config ME_SPEC_11
I would remove all ME_SPEC_x and just use the hardcoded numbers. It saves some code lines and is still obvious to everyone who reads it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I817d14e52b0d353bbb4316d6362fcb80cbec3cda
Gerrit-Change-Number: 73128
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 17:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment