Attention is currently required from: Martin Roth, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/51133 )
Change subject: Add support to switch LSPCON modes ......................................................................
Patch Set 11: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/51133/comment/f284a55f_2d1d1df7 PS9, Line 11: The chip defaults to LS mode. Maybe explain this, e.g.
[...] which means the display engine has to deliver an HDMI-protocol signal which is only shifted to HDMI levels.
https://review.coreboot.org/c/libgfxinit/+/51133/comment/8bd86b3d_24944a6f PS9, Line 16: level shifter mode `level-shifter mode` would probably read better, or `LS mode` like above.
Patchset:
PS11: Looks I forgot to publish some old drafts, sorry.
Did you check possible delays for normal DP sinks? IIRC, you mentioned something on IRC, Angel.
File common/hw-gfx-dp_dual_mode.adb:
https://review.coreboot.org/c/libgfxinit/+/51133/comment/fcdc5d4d_7be83bf1 PS11, Line 87: end case; Could also remove all the pragmas here and put a single one around each call. That would also make the warning justification obsolete, I think.
-
Nico Huber (Code Review)