Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Karthik Ramasubramanian, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86361?usp=email )
Change subject: soc/intel/common: Add low battery shutdown function
......................................................................
Patch Set 3:
(1 comment)
File src/include/reset.h:
https://review.coreboot.org/c/coreboot/+/86361/comment/84130a44_e544422e?usp... :
PS3, Line 51: * 2. Introduces a short delay to allow time for logging.
How is the short delay allowing logging ? If this is just for logging why is it arbitrarily 3 second […]
I think the time is really to allow the user to see the low battery screen (and the comment here should reflect that). Maybe we should wrap the code below in `#if CONFIG(PLATFORM_HAS_LOW_BATTERY_INDICATOR)` to make it clear that this is only meant for use together with the splash screen indicator, even though it's gonna get linker-GCed when disabled anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86361?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92e9003c70c2608770972f1a302f954ebdf17bc4
Gerrit-Change-Number: 86361
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com