Change in coreboot[master]: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 k...

[Johnny Li (Code Review)]

Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
......................................................................

mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz
for trackpad

The current I2C5 bus frequency is 367 kHZ, which does not meet the spec.
This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring
the bus frequency closer to 400kHz.

BUG=b:153588771
TEST=Verified that I2C5 frequency is between 389-396kHz.
Signed-off-by: Johnny Li 
Change-Id: If59502aec7c3ab55864a518d626cde52aee18373
---
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
1 file changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/43746/1

diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
index 0944765..d84ca1d 100644
--- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
@@ -1,5 +1,48 @@
 chip soc/intel/tigerlake
    register "SaGv" = "SaGv_Disabled"
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| chipset_lockdown  | CHIPSET_LOCKDOWN_COREBOOT |
+	#| GSPI0             | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#|                   | before memory is up       |
+	#| GSPI1             | Fingerprint MCU           |
+	#| I2C0              | Audio                     |
+	#| I2C1              | Touchscreen               |
+	#| I2C2              | WLAN, SAR0                |
+	#| I2C3              | Camera, SAR1              |
+	#| I2C5              | Trackpad                  |
+	#+-------------------+---------------------------+
+	register "common_soc_config" = "{
+		.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
+		.gspi[0] = {
+			.speed_mhz = 1,
+			.early_init = 1,
+		},
+                .i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[1] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[2] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[3] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 163,
+				.scl_hcnt = 75,
+				.sda_hold = 36,
+			},
+		},
+	}"
    device domain 0 on
    	device pci 15.0 on
    		chip drivers/i2c/generic

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43746/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43746/1/src/mainboard/google/voltee... 
PS1, Line 24:                 
tabs please

[Johnny Li (Code Review)]

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43746

to look at the new patch set (#2).

Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
......................................................................

mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz
for trackpad

The current I2C5 bus frequency is 367 kHZ, which does not meet the spec.
This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring
the bus frequency closer to 400kHz.

BUG=b:153588771
TEST=Verified that I2C5 frequency is between 389-396kHz.
Signed-off-by: Johnny Li 
Change-Id: If59502aec7c3ab55864a518d626cde52aee18373
---
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
1 file changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/43746/2

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
......................................................................

Patch Set 2: Code-Review+1

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
......................................................................

Patch Set 2: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz for trackpad
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43746/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43746/2//COMMIT_MSG@7 
PS2, Line 7: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz
           : for trackpad
This is a little long, try to keep first line to 75 chars or less; maybe:
`mb/google/volteer: Volteer: Tune I2C5 bus frequency`

Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz

[Johnny Li (Code Review)]

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43746

to look at the new patch set (#3).

Change subject: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz 
......................................................................

mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz

The current I2C5 bus frequency is 367 kHZ, which does not meet the spec.
This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring
the bus frequency closer to 400kHz.

BUG=b:153588771
TEST=Verified that I2C5 frequency is between 389-396kHz.
Signed-off-by: Johnny Li 
Change-Id: If59502aec7c3ab55864a518d626cde52aee18373
---
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
1 file changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/43746/3

Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz

[Johnny Li (Code Review)]

Johnny Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz 
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

already to change subject

https://review.coreboot.org/c/coreboot/+/43746/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43746/2//COMMIT_MSG@7 
PS2, Line 7: mb/google/volteer/var/volteer: Increase I2C5 bus freq closer to 400 kHz
           : for trackpad
> This is a little long, try to keep first line to 75 chars or less; maybe: […]

Done

Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz 
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz 
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43746/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43746/1/src/mainboard/google/voltee... 
PS1, Line 24:
> tabs please

Done

Change in coreboot[master]: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43746 )

Change subject: mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz 
......................................................................

mb/google/volteer/var/volteer: I2C5 trackpad bus freq 400 kHz

The current I2C5 bus frequency is 367 kHZ, which does not meet the spec.
This change updates scl_lcnt, scl_hcnt, scl_hcnt value for I2C5 to bring
the bus frequency closer to 400kHz.

BUG=b:153588771
TEST=Verified that I2C5 frequency is between 389-396kHz.
Signed-off-by: Johnny Li 
Change-Id: If59502aec7c3ab55864a518d626cde52aee18373
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43746
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Caveh Jalali 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
1 file changed, 43 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Caveh Jalali: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved
  Johnny Li: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
index 54566f7..c7350cb 100644
--- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
@@ -1,5 +1,48 @@
 chip soc/intel/tigerlake
    register "SaGv" = "SaGv_Disabled"
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| chipset_lockdown  | CHIPSET_LOCKDOWN_COREBOOT |
+	#| GSPI0             | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#|                   | before memory is up       |
+	#| GSPI1             | Fingerprint MCU           |
+	#| I2C0              | Audio                     |
+	#| I2C1              | Touchscreen               |
+	#| I2C2              | WLAN, SAR0                |
+	#| I2C3              | Camera, SAR1              |
+	#| I2C5              | Trackpad                  |
+	#+-------------------+---------------------------+
+	register "common_soc_config" = "{
+		.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
+		.gspi[0] = {
+			.speed_mhz = 1,
+			.early_init = 1,
+		},
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[1] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[2] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[3] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 163,
+				.scl_hcnt = 75,
+				.sda_hold = 36,
+			},
+		},
+	}"
    device domain 0 on
    	device pci 15.0 on
    		chip drivers/i2c/generic