Attention is currently required from: Frank Wu, John Su, Furquan Shaikh, Alan Lee, Angel Pons, Ivy Jian, EricR Lai.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49783 )
Change subject: drivers/generic/bayhub_lv2: Add driver for BayHub lv2
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49783/comment/75b2a84b_6916fa94
PS7, Line 13:
We lost the TEST= message in patch set 3.
Hazards of using the gerrit editor. :)
File src/drivers/generic/bayhub_lv2/lv2.c:
https://review.coreboot.org/c/coreboot/+/49783/comment/dbf56d4b_aac65768
PS7, Line 19: if (config && config->power_saving) {
Maybe:
if (!config || !config->power_saving)
return;
Then you don't need to indent all of the below lines.
https://review.coreboot.org/c/coreboot/+/49783/comment/c2a3ef08_fc56ce3b
PS7, Line 26: 0x0FFFFFFF
I'm not positive, but I think Furquan might have wanted macros for the mask values as well. I'll let him answer if he didn't but since that was specifically the value he highlighted, I'd think it's a safe assumption.
#define LV2_PCI_TIMER_MASK or some such.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc1340b1a6fe7063d16c8ea16488d6e2b8b308cc
Gerrit-Change-Number: 49783
Gerrit-PatchSet: 7
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 28 Jan 2021 21:05:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment