Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29858 )
Change subject: mb/siemens/mc_{apl1,tcu3}: [test] Fix sizeof on array function ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/29858/1/src/mainboard/siemens/mc_apl1/romsta... File src/mainboard/siemens/mc_apl1/romstage.c:
https://review.coreboot.org/#/c/29858/1/src/mainboard/siemens/mc_apl1/romsta... PS1, Line 51: if (hwilib_get_field(SPD, spd, sizeof(*spd)) != sizeof(*spd)) { Hmmm..no clue what you are after. What I need here is the size of the whole array spd in bytes. And this is what I get with the current code (sizeof(spd)). Your change would provide the size of the first element of the array which would be 1 byte. And this is not what I need here. What is your motivation for suggesting this change?