[XS] Change in coreboot[main]: ec/google/chromeec: Enable ACPI memory mapping for Microchip EC

[Jérémy Compostella (Code Review)]

Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85886?usp=email )

Change subject: ec/google/chromeec: Enable ACPI memory mapping for Microchip EC
......................................................................

ec/google/chromeec: Enable ACPI memory mapping for Microchip EC

This commit introduces an automatic linkage between the Microchip
EC (EC_GOOGLE_CHROMEEC_MEC) and ACPI memory
mapping (EC_GOOGLE_CHROMEEC_ACPI_MEMMAP) options. This linkage is
enabled when the Microchip EC is selected.

Certain data registers in Microchip ECs cannot be accessed via I/O
space. Instead, an indirection mechanism is required for register
access. When using such an EC, coreboot must publish ACPI information
to access these data registers through ACPI data ports 66h/62h.

Analysis of the coreboot codebase has revealed that the
EC_GOOGLE_CHROMEEC_MEC and EC_GOOGLE_CHROMEEC_ACPI_MEMMAP options are
consistently used together. This commit streamlines this dependency by
linking the two options.

TEST=/sys/class/power_supply/BAT0/* reports consistent values on
     fatcat board.

Change-Id: Ib4120a6d0ba2f4785e8b07b33943010e58bcbdd3
Signed-off-by: Jeremy Compostella 
---
M src/ec/google/chromeec/Kconfig
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/fatcat/Kconfig
M src/mainboard/google/glados/Kconfig
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/kunimitsu/Kconfig
M src/mainboard/intel/strago/Kconfig
7 files changed, 1 insertion(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85886/1

diff --git a/src/ec/google/chromeec/Kconfig b/src/ec/google/chromeec/Kconfig
index cf3dc9f..4704c48 100644
--- a/src/ec/google/chromeec/Kconfig
+++ b/src/ec/google/chromeec/Kconfig
@@ -94,6 +94,7 @@
    depends on EC_GOOGLE_CHROMEEC_LPC
    def_bool n
    select EC_GOOGLE_COMMON_MEC
+	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    help
      Microchip EC variant for LPC register access.

diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig
index 37832de..2bb6b92 100644
--- a/src/mainboard/google/cyan/Kconfig
+++ b/src/mainboard/google/cyan/Kconfig
@@ -5,7 +5,6 @@
    select ACPI_GNVS_USB_CHARGECTL
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select EC_GOOGLE_CHROMEEC_BOARDID
    select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig
index 3061004..37ba330 100644
--- a/src/mainboard/google/fatcat/Kconfig
+++ b/src/mainboard/google/fatcat/Kconfig
@@ -61,13 +61,11 @@

config BOARD_GOOGLE_FATCAT
    select BOARD_GOOGLE_MODEL_FATCAT
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select EC_GOOGLE_CHROMEEC_MEC
    select MAINBOARD_USES_IFD_EC_REGION

config BOARD_GOOGLE_FATCATISH
    select BOARD_GOOGLE_MODEL_FATCAT
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select EC_GOOGLE_CHROMEEC_MEC
    select MAINBOARD_USES_IFD_EC_REGION

diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index 0bea9e7..57d54d0 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -6,7 +6,6 @@
    select DRIVERS_I2C_GENERIC
    select DRIVERS_I2C_NAU8825
    select EC_GOOGLE_CHROMEEC
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select EC_GOOGLE_CHROMEEC_BOARDID
    select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
diff --git a/src/mainboard/intel/adlrvp/Kconfig b/src/mainboard/intel/adlrvp/Kconfig
index 279a8f9..db5e2d9 100644
--- a/src/mainboard/intel/adlrvp/Kconfig
+++ b/src/mainboard/intel/adlrvp/Kconfig
@@ -60,7 +60,6 @@
    select BOARD_INTEL_ADLRVP_COMMON
    select DRIVERS_INTEL_MIPI_CAMERA
    select DRIVERS_INTEL_PMC
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select EC_GOOGLE_CHROMEEC_MEC
    select INTEL_LPSS_UART_FOR_CONSOLE
    select SOC_INTEL_ALDERLAKE_PCH_P
diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig
index e2a16fc..0a84d36 100644
--- a/src/mainboard/intel/kunimitsu/Kconfig
+++ b/src/mainboard/intel/kunimitsu/Kconfig
@@ -9,7 +9,6 @@
    select DRIVERS_I2C_GENERIC
    select DRIVERS_I2C_NAU8825
    select EC_GOOGLE_CHROMEEC
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select EC_GOOGLE_CHROMEEC_BOARDID
    select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig
index 67030e2..3cb99eb 100644
--- a/src/mainboard/intel/strago/Kconfig
+++ b/src/mainboard/intel/strago/Kconfig
@@ -10,7 +10,6 @@
    select EC_GOOGLE_CHROMEEC_BOARDID
    select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select ENABLE_BUILTIN_COM1
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES