[M] Change in coreboot[main]: mb/google/guybrush: Update DDI descriptor definition - coreboot-gerrit

5 Jan 2024


      Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email )
Change subject: mb/google/guybrush: Update DDI descriptor definition
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/79793/comment/6fcbc476_a1a719d4 :
PS3, Line 7: true
...
That was my thought as well, but I was trying to preserve the logic. […]
SGTM.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6
Gerrit-Change-Number: 79793
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Jan 2024 18:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Jon Murphy jpmurphy@google.com
Gerrit-MessageType: comment