Attention is currently required from: Cliff Huang, Eric Lai, Felix Held, Jérémy Compostella, Lance Zhao, Nico Huber, Tim Wawrzynczak.
Hello Cliff Huang, Eric Lai, Jérémy Compostella, Lance Zhao, Nico Huber, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82643?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Nico Huber, Code-Review+2 by Eric Lai, Code-Review+2 by Tim Wawrzynczak, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: acpi/acpi_apic;arch/x86/acpi: better document ACPI_NO_PCAT_8259 case ......................................................................
acpi/acpi_apic;arch/x86/acpi: better document ACPI_NO_PCAT_8259 case
Both acpi_create_madt_sci_override and acpi_sci_int have special handling for the ACPI_NO_PCAT_8259 case, but those cases weren't exactly obvious, so add a comment with the reason for that.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ia6dcf59d5ab9226c61e9c4af95a73a07771b71d1 --- M src/acpi/acpi_apic.c M src/arch/x86/acpi.c 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/82643/2