Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53922 )
Change subject: soc/amd/common/block/pci: Introduce struct pci_routing_info
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/amd_pci_util.h:
https://review.coreboot.org/c/coreboot/+/53922/comment/36ace40f_9b888f78
PS3, Line 34: enum pci_routing_swizzle {
: PCI_SWIZZLE_ABCD = 0,
: PCI_SWIZZLE_BCDA,
: PCI_SWIZZLE_CDAB,
: PCI_SWIZZLE_DABC,
: };
hmm, is this even used? this is also already implicitly defined in pcie_swizzle_table
just saw that it's used
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a8d988d125f407f0aa7bc1722d432446aa9aff8
Gerrit-Change-Number: 53922
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Sat, 08 May 2021 00:53:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment