Attention is currently required from: Felix Singer, Paul Menzel, Michał Kopeć, Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 )
Change subject: mb/msi/ms7d25: Add support for DDR5 variant ......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68448/comment/ccdf2ffc_cf8caf9e PS7, Line 10: difference is the board's DDR5 memory design.
Why not, in the dmidecode outputs, I can see that the original firmware initialized the revision to […]
We also have the PCB rev 2.1, but SMBIOS reports 2.0, I have set the default to 2.0, people may always override it via menuconfig
Patchset:
PS7:
They are the same. It has been checked.
Ack
File configs/config.dell_precision_t1650:
PS7:
Yeah.. `$ history`: […]
Removed...
File src/mainboard/msi/ms7d25/Kconfig:
https://review.coreboot.org/c/coreboot/+/68448/comment/94a48693_b4ca2ff6 PS7, Line 35: default "Default string"
Hmmm
Yup, vendor firmware leaves such nits...
File src/mainboard/msi/ms7d25/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/68448/comment/82ea72e0_a3b5c753 PS7, Line 15: .UserBd = BOARD_TYPE_DESKTOP_2DPC,
No longer FIXME? Makes sense
I thought I removed it long time ago, when DESKTOP_2DPC was not defined... Anyways FIXME shouldn't be here any longer.
-
Michał Żygowski (Code Review)