Change in coreboot[master]: soc/amd/cezanne: Add reset.c

[Mathew King (Code Review)]

Mathew King has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48534 )

Change subject: soc/amd/cezanne: Add reset.c
......................................................................

soc/amd/cezanne: Add reset.c

Add an empty reset.c so that mainboards can use this chip.

Change-Id: Ie4f9712ff2b21f27c46f0f0d99dfd8a5e9a5db4f
---
M src/soc/amd/cezanne/Makefile.inc
A src/soc/amd/cezanne/reset.c
2 files changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48534/1

diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.inc
index df3355e..700b55a 100644
--- a/src/soc/amd/cezanne/Makefile.inc
+++ b/src/soc/amd/cezanne/Makefile.inc
@@ -5,10 +5,13 @@
 all-y += config.c

bootblock-y	+= bootblock.c
+bootblock-y	+= reset.c

romstage-y	+= romstage.c
+romstage-y	+= reset.c

ramstage-y	+= chip.c
+ramstage-y	+= reset.c

CPPFLAGS_common += -I$(src)/soc/amd/cezanne/include

diff --git a/src/soc/amd/cezanne/reset.c b/src/soc/amd/cezanne/reset.c
new file mode 100644
index 0000000..7a280f2
--- /dev/null
+++ b/src/soc/amd/cezanne/reset.c
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <reset.h>
+
+void do_board_reset(void)
+{
+	/* TODO */
+}

[Mathew King (Code Review)]

Hello Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48534

to look at the new patch set (#2).

Change subject: soc/amd/cezanne: Add reset.c
......................................................................

soc/amd/cezanne: Add reset.c

Add an empty reset.c so that mainboards can use this chip.

Change-Id: Ie4f9712ff2b21f27c46f0f0d99dfd8a5e9a5db4f
---
M src/soc/amd/cezanne/Makefile.inc
A src/soc/amd/cezanne/reset.c
2 files changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48534/2

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48534 )

Change subject: soc/amd/cezanne: Add reset.c
......................................................................

Patch Set 2:

FYI: i'll push a fixed version of https://review.coreboot.org/c/coreboot/+/48488 today

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48534 )

Change subject: soc/amd/cezanne: Add reset.c
......................................................................

Patch Set 2:

i just pushed a new version of CB:48488; you can abandon this one and rebase the guybrush mainboard on top of this. you should also run "make gitconfig" on your system, so that it'll add the commit hooks that will add the missing sign off by line which is currently missing which causes the buildbot's complaints

[Mathew King (Code Review)]

Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48534

to look at the new patch set (#3).

Change subject: soc/amd/cezanne: Add reset.c
......................................................................

soc/amd/cezanne: Add reset.c

Add an empty reset.c so that mainboards can use this chip.

Change-Id: Ie4f9712ff2b21f27c46f0f0d99dfd8a5e9a5db4f
Signed-off-by: Mathew King 
---
M src/soc/amd/cezanne/Makefile.inc
A src/soc/amd/cezanne/reset.c
2 files changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/48534/3

[Mathew King (Code Review)]

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48534 )

Change subject: soc/amd/cezanne: Add reset.c
......................................................................

Patch Set 3:
> Patch Set 2:
>
> i just pushed a new version of CB:48488; you can abandon this one and rebase the guybrush mainboard on top of this. you should also run "make gitconfig" on your system, so that it'll add the commit hooks that will add the missing sign off by line which is currently missing which causes the buildbot's complaints

Thank you!

[Mathew King (Code Review)]

Mathew King has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48534 )

Change subject: soc/amd/cezanne: Add reset.c
......................................................................

Abandoned