Attention is currently required from: Jeff Daly, Jonathan Zhang, Angel Pons, Arthur Heymans, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69760 )
Change subject: [NOTFORMERGE] squashed intel pmutil ops ......................................................................
Patch Set 1:
(8 comments)
File src/arch/x86/include/arch/io_bitops.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/c7d95a65_bd8c8001 PS1, Line 65: outl(reg , addr); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/1a627adf_6881a9ae PS1, Line 73: outw(reg , addr); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/74e9e495_cc5b0118 PS1, Line 81: outb(reg , addr); space prohibited before that ',' (ctx:WxW)
File src/southbridge/intel/common/pmbase.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/fe500363_705d7ac8 PS1, Line 26: #if 0 Consider removing the code enclosed by this #if 0 and its #endif
File src/southbridge/intel/common/tco.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/88be06be_5c6acf23 PS1, Line 11: #define BOOT_STS (1 << 18) ?? 16 bit register (1 << 2) on TCO2_STS space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/67d4847b_6bb2a5b6 PS1, Line 11: #define BOOT_STS (1 << 18) ?? 16 bit register (1 << 2) on TCO2_STS spaces required around that '?' (ctx:WxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/aabf42af_27b6d0d6 PS1, Line 11: #define BOOT_STS (1 << 18) ?? 16 bit register (1 << 2) on TCO2_STS spaces required around that '?' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163933): https://review.coreboot.org/c/coreboot/+/69760/comment/2198c73c_ad1d8b84 PS1, Line 11: #define BOOT_STS (1 << 18) ?? 16 bit register (1 << 2) on TCO2_STS Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)