Attention is currently required from: Subrata Banik, Sridhar Siricilla, Kyösti Mälkki, Elyes Haouas.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 )
Change subject: soc/intel/common: Add code to order the different types of cores ......................................................................
Patch Set 15:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72132/comment/b08af3b9_b0cee4d0 PS15, Line 7: Add code to Redundant as patches are about code.
https://review.coreboot.org/c/coreboot/+/72132/comment/8e6a9418_65f5d3db PS15, Line 11: for c in {0..7}; Please add a blank line above.
https://review.coreboot.org/c/coreboot/+/72132/comment/90b41501_0078acc1 PS15, Line 11: for c in {0..7}; : do : cat /sys/devices/system/cpu/cpu$c/topology/thread_siblings_list; : done Shorter:
$ grep . /sys/devices/system/cpu/cpu*/topology/thread_siblings_list
https://review.coreboot.org/c/coreboot/+/72132/comment/f1428c1d_cdd22d31 PS15, Line 11: for c in {0..7}; : do : cat /sys/devices/system/cpu/cpu$c/topology/thread_siblings_list; : done : 0-1 : 4 : 5 : 6 : 7 : 0-1 : 2-3 : 2-3 You could use Markdown formatting, and indent code blocks by four spaces.
https://review.coreboot.org/c/coreboot/+/72132/comment/a2fab999_68f34663 PS15, Line 24: Existing code presents mix of different cores to OS and causes CPU load : balancing and power/performance impact. Why? What ordering does the OS require? Maybe reference the kernel source code.