Attention is currently required from: Tarun Tuli, Jamie Ryu, Paul Menzel, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73272 )
Change subject: soc/intel/cmn/tom: Cache TOM region early
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73272/comment/d39ade98_26223c73
PS1, Line 7: soc/intel/cmn/tom: Early caching of TOM region
Please make it a statement: Cache TOM region early
Ack
https://review.coreboot.org/c/coreboot/+/73272/comment/e14682df_7646f964
PS1, Line 12:
Why is determining TOM take 50 ms? Please elaborate in the commit message.
please read the line between 13-19, that explains why we are seeing 50ms savings (FSP-M and late romstage uses this
uncached TOM range for various purposes). Sorry! I don't know how to make more elaborative commit msg.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29d3e1df91c6057280bdf7fb6a4a356db31a408f
Gerrit-Change-Number: 73272
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 15:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment