Change in coreboot[master]: superio/nct5539d: include the missing acpi.h and ssdt.h

[Maxim Polyakov (Code Review)]

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37274 )

Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h
......................................................................

superio/nct5539d: include the missing acpi.h and ssdt.h

Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024
Signed-off-by: Maxim Polyakov 
---
M src/superio/nuvoton/nct5539d/superio.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/37274/1

diff --git a/src/superio/nuvoton/nct5539d/superio.c b/src/superio/nuvoton/nct5539d/superio.c
index 4f2a4a5..bdb50c7 100644
--- a/src/superio/nuvoton/nct5539d/superio.c
+++ b/src/superio/nuvoton/nct5539d/superio.c
@@ -24,7 +24,8 @@
 #include <pc80/keyboard.h>
 #include <stdlib.h>
 #include <superio/conf_mode.h>
-
+#include <superio/common/ssdt.h>
+#include <arch/acpi.h>
 #include "nct5539d.h"

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37274 )

Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/37274/1/src/superio/nuvoton/nct5539... 
File src/superio/nuvoton/nct5539d/superio.c:

https://review.coreboot.org/c/coreboot/+/37274/1/src/superio/nuvoton/nct5539... 
PS1, Line 27: #include <superio/common/ssdt.h>
            : #include <arch/acpi.h>
Looks like ACPI stuffs in this file are guarded:
 #if CONFIG(HAVE_ACPI_TABLES)

Maybe guard the includes as well? Not sure if it matters tbh.

[Maxim Polyakov (Code Review)]

Hello Felix Held, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37274

to look at the new patch set (#2).

Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h
......................................................................

superio/nct5539d: include the missing acpi.h and ssdt.h

Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024
Signed-off-by: Maxim Polyakov 
---
M src/superio/nuvoton/nct5539d/superio.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/37274/2

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37274 )

Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37274/1/src/superio/nuvoton/nct5539... 
File src/superio/nuvoton/nct5539d/superio.c:

https://review.coreboot.org/c/coreboot/+/37274/1/src/superio/nuvoton/nct5539... 
PS1, Line 27: #include <superio/common/ssdt.h>
            : #include <arch/acpi.h>
> Looks like ACPI stuffs in this file are guarded: […]

Thanks for the review
I think it's better to add this.

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37274 )

Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h
......................................................................

Patch Set 2: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37274 )

Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h
......................................................................

superio/nct5539d: include the missing acpi.h and ssdt.h

Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024
Signed-off-by: Maxim Polyakov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37274
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
---
M src/superio/nuvoton/nct5539d/superio.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/src/superio/nuvoton/nct5539d/superio.c b/src/superio/nuvoton/nct5539d/superio.c
index 4f2a4a5..45187ac 100644
--- a/src/superio/nuvoton/nct5539d/superio.c
+++ b/src/superio/nuvoton/nct5539d/superio.c
@@ -24,9 +24,12 @@
 #include <pc80/keyboard.h>
 #include <stdlib.h>
 #include <superio/conf_mode.h>
-
 #include "nct5539d.h"

+#if CONFIG(HAVE_ACPI_TABLES)
+#include <superio/common/ssdt.h>
+#include <arch/acpi.h>
+#endif

static void nct5539d_init(struct device *dev)
 {