Sakari Ailus has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36721 )
Change subject: mb/google/poppy: Declare output GPIOs as pull-downs ......................................................................
mb/google/poppy: Declare output GPIOs as pull-downs
The pull direction is used to determine the initial state of the pin. If no pull direction is specified, the pin will remain as input. Fix this.
Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I1158bc8aaa447b223e8ce25d808348e758de28c5 --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/36721/1
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 5eaf5b7..d3fafe9 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -142,21 +142,21 @@ 2 } /* GPIO.4 is AVDD pin for user facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { 4 } /* GPIO.5 is XSHUTDOWN pin for user facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { 5 } /* GPIO.9 is XSHUTDOWN pin for world facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { @@ -188,7 +188,7 @@ GPO2, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) @@ -199,7 +199,7 @@ GRST, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) @@ -210,7 +210,7 @@ GPO4, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36721 )
Change subject: mb/google/poppy: Declare output GPIOs as pull-downs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36721/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36721/1//COMMIT_MSG@11 PS1, Line 11: BUG=chromium:959232
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36721 )
Change subject: mb/google/poppy: Declare output GPIOs as pull-downs ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has uploaded a new patch set (#2) to the change originally created by Sakari Ailus. ( https://review.coreboot.org/c/coreboot/+/36721 )
Change subject: mb/google/poppy: Declare output GPIOs as pull-downs ......................................................................
mb/google/poppy: Declare output GPIOs as pull-downs
The pull direction is used to determine the initial state of the pin. If no pull direction is specified, the pin will remain as input. Fix this.
BUG=chromium:959232
Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I1158bc8aaa447b223e8ce25d808348e758de28c5 --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/36721/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36721 )
Change subject: mb/google/poppy: Declare output GPIOs as pull-downs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36721/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36721/1//COMMIT_MSG@11 PS1, Line 11:
BUG=chromium:959232
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36721 )
Change subject: mb/google/poppy: Declare output GPIOs as pull-downs ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36721 )
Change subject: mb/google/poppy: Declare output GPIOs as pull-downs ......................................................................
mb/google/poppy: Declare output GPIOs as pull-downs
The pull direction is used to determine the initial state of the pin. If no pull direction is specified, the pin will remain as input. Fix this.
BUG=chromium:959232
Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I1158bc8aaa447b223e8ce25d808348e758de28c5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36721 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 5eaf5b7..d3fafe9 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -142,21 +142,21 @@ 2 } /* GPIO.4 is AVDD pin for user facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { 4 } /* GPIO.5 is XSHUTDOWN pin for user facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { 5 } /* GPIO.9 is XSHUTDOWN pin for world facing camera */ - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) { @@ -188,7 +188,7 @@ GPO2, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) @@ -199,7 +199,7 @@ GRST, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,) @@ -210,7 +210,7 @@ GPO4, 1, Connection ( - GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, + GpioIo (Exclusive, PullDown, 0x0000, 0x0000, IoRestrictionOutputOnly, "\_SB.PCI0.I2C2.PMIC", 0x00, ResourceConsumer,,)
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Sakari Ailus (Code Review)