Attention is currently required from: Raul Rangel, Angel Pons.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50150 )
Change subject: soc/amd/stoneyridge/psp: fix check of MSR_PSP_ADDR contents
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/stoneyridge/psp.c:
https://review.coreboot.org/c/coreboot/+/50150/comment/3691c3ea_3de6f8ea
PS1, Line 48: if (!psp_mmio) {
If in doubt, we could simply treat both all-zeroes and all-ones as invalid values.
the Stoneyridge datasheet says that it's all zeros if uninitialized. The datasheet for Picasso says the same and there I've verified it on hardware
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06399ac9cb9c90701dbcba71cbc808a0d7e6ea0d
Gerrit-Change-Number: 50150
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 31 Jan 2021 01:12:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment