Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38640 )
Change subject: cpu: Add microcode at pre-defined address
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG@7
PS6, Line 7: c
the assembly code around FSP-T invocation actually finds microcode location and size. […]
I'm aware that it's not possible to give the microcode location to FSP-T during runtime.
Coreboot has assembly code using only registers (for pre-CAR use) to find the location of the microcode cbfs file and then find the proper update and do the update itself. So using that and completely skipping FSP-T doing the update would be preferable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c02601a7ac64078e556e2032baeccaf27f77da2
Gerrit-Change-Number: 38640
Gerrit-PatchSet: 7
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 17 Feb 2020 07:25:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment