Attention is currently required from: Furquan Shaikh, Henry Sun, Karthik Ramasubramanian. Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51153 )
Change subject: mb/google/dedede/var/drawcia: Re-tune override GPIO table ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/51153/comment/26fb4027_e168964e PS3, Line 28: board_version == 6 || board_version == 8
Yes, HW engineer mentioned that the external pull-up is not going to be stuffed in the upcoming Draw […]
So the external pull is the desired future direction, right? And from reading this it seems like 6 and 8 have the external pull, but 7 doesn't.
Wouldn't you expect versions 9+ to also have the external pull? So would (board_version == 6 || board_version >= 8) be better then?
-
Evan Green (Code Review)