Attention is currently required from: David Wu, Sumeet R Pawnikar. Peter Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59091 )
Change subject: mb/google/brya/var/kano: set power limits for thermal ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59091/comment/f3215c1a_daade847 PS1, Line 12: build pass
Hi Peter, could you share test results with power limits value to issue 205648035 for reference here […]
Hi Sumeet the power limit setting we verify in A stage for reference, we will verify again in next stage (EVT) and provide the test result for reference.
File src/mainboard/google/brya/variants/kano/ramstage.c:
https://review.coreboot.org/c/coreboot/+/59091/comment/ed2dc52f_7a2aec22 PS1, Line 8: bug:191906315 comment #10
Can you check if performance config values suits your system design and battery specs ?
Base on thermal test result in A stage, both of the different setting can meet customer's requirement, we also need to verify in EVT/DVT stage to check the performance behavior.
-
Peter Ou (Code Review)