Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Matt DeVillier, Michał Żygowski, Piotr Król.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78743?usp=email )
Change subject: soc/intel/braswell: Unify DPTF enablement
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
Thanks for cleaning this up!
File src/mainboard/google/cyan/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/78743/comment/f4799e13_51d05a0f :
PS2, Line 98: off
I would assume that `DptfDisable` had the strongest meaning (i.e. the blob
actually disables the device, while `off` only made coreboot ignore it).
As it wasn't set, shouldn't we turn the device `on` here?
Same for Strago.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78743?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8fc1b63eda0dc2e047d9cb1e11a02d41ab8b2ad7
Gerrit-Change-Number: 78743
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 13:16:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment