Attention is currently required from: Angel Pons, Dinesh Gehlot, Jayvik Desai.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )
Change subject: vc/google/chromeos: Enable eSOL config with libgfx and uGOP ......................................................................
Patch Set 12: Code-Review+2
(3 comments)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83705/comment/e3bb4d42_47dfbf42?usp... : PS6, Line 109: SOC_INTEL_METEORLAKE_SIGN_OF_LIFE
FSP_UGOP_ESOL
Acknowledged
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83705/comment/fae370a0_1a2211d1?usp... : PS9, Line 106: bool : default y if FSP_UGOP_EARLY_SIGN_OF_LIFE || MAINBOARD_HAS_EARLY_LIBGFXINIT : default n
nit: I think this is a less verbose equivalent: […]
Acknowledged
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83705/comment/f0cc0b69_0fd1fdfb?usp... : PS11, Line 111:
one empty line
Acknowledged