Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69916 )
Change subject: soc/amd/mendocino: Update XHCI GPE to use constant ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69916/comment/31aefe1b_136986f4 PS2, Line 10: This commit changes This is redundant, and imperative mood could be used.
…, so change existing code over to use ….
https://review.coreboot.org/c/coreboot/+/69916/comment/7037349d_d1c79d11 PS2, Line 9: The GPE number used for XHCI has now been defined : in AMD's common code. Please reference the commit.
https://review.coreboot.org/c/coreboot/+/69916/comment/4e1633ba_67140f30 PS2, Line 9: The GPE number used for XHCI has now been defined : in AMD's common code. This commit changes over existing : code to use this new definition. Please reflow for 72 characters per line. (It fits in two lines.)
File src/soc/amd/common/block/xhci/elog.c:
https://review.coreboot.org/c/coreboot/+/69916/comment/87a29e07_4d09a3af PS2, Line 56: switch (protocol->major_rev) { This seems like a separate bug fix. Please split it into a separate commit.