Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41853 )
Change subject: mb/google/dedede: config spk_en gpio to low by default ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@9 PS2, Line 9: gpio speaker enable gpio
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@10 PS2, Line 10: so defaults it to 0 configure it low?
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@12 PS2, Line 12: BRANCH=None not needed
https://review.coreboot.org/c/coreboot/+/41853/2//COMMIT_MSG@14 PS2, Line 14: tested tested speaker playback works fine?
-
Aamir Bohra (Code Review)