Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede: Add ACPI support for camera in magolor ......................................................................
mb/google/dedede: Add ACPI support for camera in magolor
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/NVM/CAM1 in devicetree
BUG=b:166527568 TEST= build and verify by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/45329/1
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 40738a0..d25db10 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -59,3 +59,5 @@ bool "-> Magolor" select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_INTEL_MIPI_CAMERA + select SOC_INTEL_COMMON_BLOCK_IPU diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index 9b7f1f4..92d1e0e 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -41,6 +41,20 @@ }"
device domain 0 on + device pci 05.0 on # IPU - MIPI Camera + chip drivers/intel/mipi_camera + register "acpi_uid" = "0x50000" + register "acpi_name" = ""IPU0"" + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + + register "cio2_num_ports" = "2" + register "cio2_lanes_used" = "{1,2}" + register "cio2_lane_endpoint[1]" = ""^I2C3.CAM1"" + register "cio2_prt[0]" = "0" + register "cio2_prt[1]" = "2" + device generic 0 on end + end + end device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on @@ -131,6 +145,75 @@ device i2c 39 on end end end # I2C 2 + device pci 15.3 on + chip drivers/intel/mipi_camera + register "acpi_hid" = ""OVTI5675"" + register "acpi_uid" = "0" + register "acpi_name" = ""CAM1"" + register "chip_name" = ""Ov 5675 Camera"" + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + + register "ssdb.lanes_used" = "2" + register "ssdb.link_used" = "1" + register "ssdb.vcm_type" = "0x0C" + register "vcm_name" = ""VCM0"" + register "num_freq_entries" = "2" + register "link_freq[0]" = "450000000" + register "remote_name" = ""IPU0"" + + register "has_power_resource" = "1" + #Controls + register "clk_panel.clks[0].clknum" = "1" #IMGCLKOUT_1 + register "clk_panel.clks[0].freq" = "1" #19.2 Mhz + + register "gpio_panel.gpio[0].gpio_num" = "GPP_D13" #power_enable_2p8 + register "gpio_panel.gpio[1].gpio_num" = "GPP_D14" #power_enable_1p2 + register "gpio_panel.gpio[2].gpio_num" = "GPP_D12" #reset + + #_ON + register "on_seq.ops_cnt" = "5" + register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" + register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" + register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(2, 5)" + register "on_seq.ops[4]" = "SEQ_OPS_GPIO_ENABLE(2, 5)" + + #_OFF + register "off_seq.ops_cnt" = "4" + register "off_seq.ops[0]" = "SEQ_OPS_CLK_DISABLE(0, 0)" + register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(2, 0)" + register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" + register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" + + device i2c 36 on end + end + chip drivers/intel/mipi_camera + register "acpi_uid" = "3" + register "acpi_name" = ""VCM0"" + register "chip_name" = ""DW AF DAC"" + register "device_type" = "INTEL_ACPI_CAMERA_VCM" + + register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC"" + register "vcm_compat" = ""dongwoon,dw9714"" + + device i2c 0C on end + end + chip drivers/intel/mipi_camera + register "acpi_uid" = "1" + register "acpi_name" = ""NVM0"" + register "chip_name" = ""GT24C64"" + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + + register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC"" + + register "nvm_size" = "0x2000" + register "nvm_pagesize" = "1" + register "nvm_readonly" = "1" + register "nvm_width" = "0x10" + + device i2c 50 on end + end + end # I2C 3 device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede: Add ACPI support for camera in magolor ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Evan Green, Marco Chen, ShawnX Tu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45329
to look at the new patch set (#2).
Change subject: mb/google/dedede: Add ACPI support for camera in magolor ......................................................................
mb/google/dedede: Add ACPI support for camera in magolor
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/NVM/CAM1 in devicetree
BUG=b:166527568 TEST= build and verify by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/45329/2
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede: Add ACPI support for camera in magolor ......................................................................
Patch Set 2: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede: Add ACPI support for camera in magolor ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45329/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45329/2//COMMIT_MSG@7 PS2, Line 7: mb/google/dedede: Add ACPI support for camera in magolor Nit: mb/google/dedede/var/magolor: Add ACPI camera support
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Evan Green, Sugnan Prabhu S, Marco Chen, Karthik Ramasubramanian, ShawnX Tu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45329
to look at the new patch set (#3).
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
mb/google/dedede/var/magolor: Add ACPI camera support
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/NVM/CAM1 in devicetree
BUG=b:166527568 TEST= build and verify by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/45329/3
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45329/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45329/2//COMMIT_MSG@7 PS2, Line 7: mb/google/dedede: Add ACPI support for camera in magolor
Nit: mb/google/dedede/var/magolor: Add ACPI camera support
done.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 4:
the cl is duplicated from cl: https://review.coreboot.org/c/coreboot/+/45093
verify on DUT by cam app
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 4:
(3 comments)
Is Magolor using MIPI camera for UFC and USB camera for WFC?
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... PS4, Line 160: register "num_freq_entries" = "2" Number of frequency entries is mentioned as 2. But only one link frequency is listed below.
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... PS4, Line 201: chip drivers/intel/mipi_camera register "acpi_hid" = "ACPI_DT_NAMESPACE_HID"
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... PS4, Line 213: register "nvm_compat" = ?
Hello build bot (Jenkins), Varshit B Pandya, Furquan Shaikh, Henry Sun, Evan Green, Rizwan Qureshi, Sugnan Prabhu S, Marco Chen, Karthik Ramasubramanian, ShawnX Tu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45329
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
mb/google/dedede/var/magolor: Add ACPI camera support
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/NVM/CAM1 in devicetree
BUG=b:166527568 TEST= build and verify by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/45329/5
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 5:
Patch Set 4:
(3 comments)
Is Magolor using MIPI camera for UFC and USB camera for WFC?
magolor using MIPI camera for WFC,and USB camera for UFC. updated in patch set 5 - define as CAM0 - one CLK output (WFC) - 4 MIPI lanes (WFC) - reset pin GPP_D12 (WFC) - I2c port 3 to camera module
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... PS4, Line 160: register "num_freq_entries" = "2"
Number of frequency entries is mentioned as 2. But only one link frequency is listed below.
done
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... PS4, Line 201: chip drivers/intel/mipi_camera
register "acpi_hid" = "ACPI_DT_NAMESPACE_HID"
vcm control chip in camera module
https://review.coreboot.org/c/coreboot/+/45329/4/src/mainboard/google/dedede... PS4, Line 213:
register "nvm_compat" = ?
drivers/intel/mipi_camera/ not define in driver
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 5: Code-Review+1
Hello build bot (Jenkins), Varshit B Pandya, Furquan Shaikh, Henry Sun, Evan Green, Rizwan Qureshi, Sugnan Prabhu S, Marco Chen, Karthik Ramasubramanian, ShawnX Tu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45329
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
mb/google/dedede/var/magolor: Add ACPI camera support
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/CAM0 in devicetree
BUG=b:166527568 TEST= build and verify by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/45329/6
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 175: register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" : register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" Is there a 5ms delay required between individual GPIO enables here? In the static ASL file, there was no delay.
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 195: ""\_SB.PCI0.I2C3.CAM1.PRIC"" Why is it relying on CAM1 Power resource when there is no CAM1?
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 200: end There is no NVM present in this camera module?
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 175: register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" : register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)"
Is there a 5ms delay required between individual GPIO enables here? In the static ASL file, there wa […]
Yes, GPIO enable delay = 5ms , run in firmware's boot up duration
coreboot/src/driver/intel/mipi_camera/chip.h
#define SEQ_OPS_GPIO_ENABLE(ind, delay) \ { .type = GPIO, .index = (ind), .action = ENABLE, .delay_ms = (delay) }
it should be executed in the driver of coreboot. coreboot/src/driver/intel/mipi_camera/camera.c
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 195: ""\_SB.PCI0.I2C3.CAM1.PRIC""
Why is it relying on CAM1 Power resource when there is no CAM1?
ok. it should be CAM0 as definition
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 200: end
There is no NVM present in this camera module?
File: coreboot/src/driver/intel/mipi_camera/chip.h
/* * Settings specific to nvram. Many values, if left as zero, will be assigned a default. * Set disable_nvm_defaults to non-zero if you want to disable the defaulting behavior * so you can use zero for a value. */ bool disable_nvm_defaults; uint32_t nvm_size; uint32_t nvm_pagesize; uint32_t nvm_readonly; uint32_t nvm_width; const char *nvm_compat;
File: coreboot/src/driver/intel/mipi_camera/camera.c
static void camera_fill_nvm(const struct device *dev) { struct drivers_intel_mipi_camera_config *config = dev->chip_info; struct acpi_dp *dsd = acpi_dp_new_table("_DSD");
if (!config->nvm_compat) return;
/* It might be possible to default size or width based on type. */ if (!config->disable_nvm_defaults && !config->nvm_pagesize) config->nvm_pagesize = 1;
if (!config->disable_nvm_defaults && !config->nvm_readonly) config->nvm_readonly = 1;
if (config->nvm_size) acpi_dp_add_integer(dsd, "size", config->nvm_size);
if (config->nvm_pagesize) acpi_dp_add_integer(dsd, "pagesize", config->nvm_pagesize);
if (config->nvm_readonly) acpi_dp_add_integer(dsd, "read-only", config->nvm_readonly);
if (config->nvm_width) acpi_dp_add_integer(dsd, "address-width", config->nvm_width);
acpi_dp_add_string(dsd, "compatible", config->nvm_compat); acpi_dp_write(dsd); }
About the EERPOM device, I'm not sure we should use "default value" or not ?? The device will be initial in mipi_camear driver.
"Shawnx.tu@intel.com" has provided the setting in previous device tree as following:
chip drivers/intel/mipi_camera register "acpi_hid" = "ACPI_DT_NAMESPACE_HID" register "acpi_uid" = "1" register "acpi_name" = ""NVM0"" register "chip_name" = ""GT24C08"" register "device_type" = "INTEL_ACPI_CAMERA_NVM"
register "pr0" = ""\_SB.PCI0.I2C3.CAM0.PRIC""
register "nvm_size" = "0x2000" register "nvm_pagesize" = "1" register "nvm_readonly" = "1" register "nvm_width" = "0x10" register "nvm_compat" = ""atmel,24c08""
device i2c 50 on end end
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 200: end
File: coreboot/src/driver/intel/mipi_camera/chip.h […]
Can Shawnx.tu@intel.com/sugnan@ comment on this?
Hello build bot (Jenkins), Varshit B Pandya, Furquan Shaikh, Henry Sun, Evan Green, Rizwan Qureshi, Sugnan Prabhu S, Marco Chen, Karthik Ramasubramanian, ShawnX Tu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45329
to look at the new patch set (#7).
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
mb/google/dedede/var/magolor: Add ACPI camera support
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/NVM/CAM0 in devicetree
BUG=b:166527568 TEST= build and verify function by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 87 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/45329/7
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/6/src/mainboard/google/dedede... PS6, Line 200: end
Can Shawnx.tu@intel. […]
I updated the NVM present in it. build a test firmware from patch set 7.
The WFC can work normally and no any error i2c fail dmesg of the device.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 7: Code-Review+2
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45329/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/7/src/mainboard/google/dedede... PS7, Line 51: register "cio2_lanes_used" = "{1,4}" shouldn't this be as follows ? register "cio2_lanes_used" = "{2}" The second entry is not required since we do not have the second camera on MIPI
also "cio2_lanes_used" defines the "data-lanes" entry under EP Shouldn't it be 2 data lanes for OVTI5675 ?
Hello Varshit B Pandya, build bot (Jenkins), Varshit B Pandya, Furquan Shaikh, Henry Sun, Evan Green, Rizwan Qureshi, Sugnan Prabhu S, Marco Chen, Karthik Ramasubramanian, ShawnX Tu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45329
to look at the new patch set (#8).
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
mb/google/dedede/var/magolor: Add ACPI camera support
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/NVM/CAM0 in devicetree
BUG=b:166527568 TEST= build and verify function by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 87 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/45329/8
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45329/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45329/7/src/mainboard/google/dedede... PS7, Line 51: register "cio2_lanes_used" = "{1,4}"
shouldn't this be as follows ? […]
Yes. from magolor schematic design, the mipi camera data is 2 lanes (port C: D0 and D1)
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 8: Code-Review+2
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
Patch Set 8: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45329 )
Change subject: mb/google/dedede/var/magolor: Add ACPI camera support ......................................................................
mb/google/dedede/var/magolor: Add ACPI camera support
1. enable DRIVERS_INTEL_MIPI_CAMERA/SOC_INTEL_COMMON_BLOCK_IPU 2. add IPU/VCM/NVM/CAM0 in devicetree
BUG=b:166527568 TEST= build and verify function by cam ap on DUT
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ica6aa8ddc03a1dab5b548a759825dd3a4de3101f Reviewed-on: https://review.coreboot.org/c/coreboot/+/45329 Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Varshit B Pandya varshit.b.pandya@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/Kconfig.name M src/mainboard/google/dedede/variants/magolor/overridetree.cb 2 files changed, 87 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Ren Kuo: Looks good to me, but someone else must approve Varshit B Pandya: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 7a53721..563a309 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -61,3 +61,5 @@ bool "-> Magolor" select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_INTEL_MIPI_CAMERA + select SOC_INTEL_COMMON_BLOCK_IPU diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index 9b7f1f4..496623c 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -41,6 +41,19 @@ }"
device domain 0 on + device pci 05.0 on # IPU - MIPI Camera + chip drivers/intel/mipi_camera + register "acpi_uid" = "0x50000" + register "acpi_name" = ""IPU0"" + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + + register "cio2_num_ports" = "1" + register "cio2_lanes_used" = "{2}" + register "cio2_lane_endpoint[0]" = ""^I2C3.CAM0"" + register "cio2_prt[0]" = "2" + device generic 0 on end + end + end device pci 14.0 on chip drivers/usb/acpi device usb 0.0 on @@ -131,6 +144,78 @@ device i2c 39 on end end end # I2C 2 + device pci 15.3 on # I2C 3 + chip drivers/intel/mipi_camera + register "acpi_hid" = ""OVTI5675"" + register "acpi_uid" = "0" + register "acpi_name" = ""CAM0"" + register "chip_name" = ""Ov 5675 Camera"" + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + + register "ssdb.lanes_used" = "2" + register "ssdb.link_used" = "1" + register "ssdb.vcm_type" = "0x0C" + register "vcm_name" = ""VCM0"" + register "num_freq_entries" = "1" + register "link_freq[0]" = "DEFAULT_LINK_FREQ" + register "remote_name" = ""IPU0"" + + register "has_power_resource" = "1" + #Controls + register "clk_panel.clks[0].clknum" = "1" #IMGCLKOUT_1 + register "clk_panel.clks[0].freq" = "1" #19.2 Mhz + + register "gpio_panel.gpio[0].gpio_num" = "GPP_D13" #power_enable_2p8 + register "gpio_panel.gpio[1].gpio_num" = "GPP_D14" #power_enable_1p2 + register "gpio_panel.gpio[2].gpio_num" = "GPP_D12" #reset + + #_ON + register "on_seq.ops_cnt" = "5" + register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" + register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" + register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(2, 5)" + register "on_seq.ops[4]" = "SEQ_OPS_GPIO_ENABLE(2, 5)" + + #_OFF + register "off_seq.ops_cnt" = "4" + register "off_seq.ops[0]" = "SEQ_OPS_CLK_DISABLE(0, 0)" + register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(2, 0)" + register "off_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" + register "off_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" + + device i2c 36 on end + end + chip drivers/intel/mipi_camera + register "acpi_uid" = "3" + register "acpi_name" = ""VCM0"" + register "chip_name" = ""DW AF DAC"" + register "device_type" = "INTEL_ACPI_CAMERA_VCM" + + register "pr0" = ""\_SB.PCI0.I2C3.CAM0.PRIC"" + register "vcm_compat" = ""dongwoon,dw9714"" + + device i2c 0C on end + + end + chip drivers/intel/mipi_camera + register "acpi_hid" = "ACPI_DT_NAMESPACE_HID" + register "acpi_uid" = "1" + register "acpi_name" = ""NVM0"" + register "chip_name" = ""GT24C08"" + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + + register "pr0" = ""\_SB.PCI0.I2C3.CAM0.PRIC"" + + register "nvm_size" = "0x2000" + register "nvm_pagesize" = "1" + register "nvm_readonly" = "1" + register "nvm_width" = "0x10" + register "nvm_compat" = ""atmel,24c08"" + + device i2c 50 on end + end + end device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
-
Justin TerAvest (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Ren Kuo (Code Review)
-
Varshit B Pandya (Code Review)