Attention is currently required from: Christian Walter, Julius Werner, Jett Rink. Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Accept Google Ti50 TPM DID:VID ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/7cd1d4d3_23213d93 PS1, Line 515: if (tpm_first_access_this_boot()) { : /* This is called for the side-effect of printing the firmware version : string */ : cr50_get_firmware_version(&ver); : }
Don't we only want to do this for cr50 not ti50?
cr50_set_board_cfg() we definitely only want to do for Cr50, not Ti50 as it emits the longer interrupt pulses under all circumstances.
I think we do want to print the ti50 version in the log. The existing cr50_ method can fulfill that purpose, though it does also try to parse a particular format. Maybe I should create a separate ti50_get_firmware_version() ?