Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42052 )
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
sb/intel/bd82x6x: Drop unneeded files from SMM
We also drop all `__unused` function attributes on these files.
Tested with BUILD_TIMELESS=1, Asus P8Z77-V LX2 remains identical.
Change-Id: I37219bddd2ad9b56711508a3d28056863123d769 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/bd82x6x/Makefile.inc M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c 3 files changed, 6 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42052/1
diff --git a/src/southbridge/intel/bd82x6x/Makefile.inc b/src/southbridge/intel/bd82x6x/Makefile.inc index cf9bf50..f83d303 100644 --- a/src/southbridge/intel/bd82x6x/Makefile.inc +++ b/src/southbridge/intel/bd82x6x/Makefile.inc @@ -25,7 +25,7 @@
ramstage-$(CONFIG_ELOG) += elog.c
-smm-y += smihandler.c me.c me_8.x.c pch.c me_common.c +smm-y += smihandler.c pch.c me_common.c
romstage-y += early_smbus.c me_status.c romstage-y += early_rcba.c diff --git a/src/southbridge/intel/bd82x6x/me.c b/src/southbridge/intel/bd82x6x/me.c index dd3ecd7..38cdb48 100644 --- a/src/southbridge/intel/bd82x6x/me.c +++ b/src/southbridge/intel/bd82x6x/me.c @@ -29,7 +29,7 @@ #endif
/* Get ME firmware version */ -static int __unused mkhi_get_fw_version(void) +static int mkhi_get_fw_version(void) { struct me_fw_version version; struct mkhi_header mkhi = { @@ -66,7 +66,7 @@ }
/* Get ME Firmware Capabilities */ -static int __unused mkhi_get_fwcaps(void) +static int mkhi_get_fwcaps(void) { u32 rule_id = 0; struct me_fwcaps cap; @@ -109,8 +109,6 @@ return 0; }
-#ifndef __SIMPLE_DEVICE__ - /* Determine the path that we should take based on ME status */ static me_bios_path intel_me_path(struct device *dev) { @@ -236,5 +234,3 @@ .vendor = PCI_VENDOR_ID_INTEL, .device = 0x1c3a, }; - -#endif /* __SIMPLE_DEVICE__ */ diff --git a/src/southbridge/intel/bd82x6x/me_8.x.c b/src/southbridge/intel/bd82x6x/me_8.x.c index 78f2817..5659f7a 100644 --- a/src/southbridge/intel/bd82x6x/me_8.x.c +++ b/src/southbridge/intel/bd82x6x/me_8.x.c @@ -34,7 +34,7 @@ name, state ? " en" : "dis"); }
-static void __unused me_print_fw_version(mbp_fw_version_name *vers_name) +static void me_print_fw_version(mbp_fw_version_name *vers_name) { if (!vers_name->major_version) { printk(BIOS_ERR, "ME: mbp missing version report\n"); @@ -72,7 +72,7 @@ }
/* Get ME Firmware Capabilities */ -static void __unused me_print_fwcaps(mbp_fw_caps *caps_section) +static void me_print_fwcaps(mbp_fw_caps *caps_section) { mefwcaps_sku *cap = &caps_section->fw_capabilities; if (!caps_section->available) { @@ -99,8 +99,6 @@ print_cap("Wireless LAN (WLAN)", cap->wlan); }
-#ifndef __SIMPLE_DEVICE__ - /* Determine the path that we should take based on ME status */ static me_bios_path intel_me_path(struct device *dev) { @@ -242,8 +240,6 @@ .device = 0x1e3a, };
-#endif /* !__SIMPLE_DEVICE__ */ - /****************************************************************************** * */ static u32 me_to_host_words_pending(void) @@ -260,7 +256,7 @@ * mbp seems to be following its own flow, let's retrieve it in a dedicated * function. */ -static int __unused intel_me_read_mbp(me_bios_payload *mbp_data) +static int intel_me_read_mbp(me_bios_payload *mbp_data) { mbp_header mbp_hdr; mbp_item_header mbp_item_hdr;
Hello Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42052
to look at the new patch set (#2).
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
sb/intel/bd82x6x: Drop unneeded files from SMM
We also drop all `__unused` function attributes on these files.
Tested with BUILD_TIMELESS=1, Asus P8Z77-V LX2 remains identical.
Change-Id: I37219bddd2ad9b56711508a3d28056863123d769 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/bd82x6x/Makefile.inc M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/ibexpeak/Makefile.inc 4 files changed, 7 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42052/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42052
to look at the new patch set (#3).
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
sb/intel/bd82x6x: Drop unneeded files from SMM
We also drop all `__unused` function attributes on these files.
Tested with BUILD_TIMELESS=1, Asus P8Z77-V LX2 remains identical.
Change-Id: I37219bddd2ad9b56711508a3d28056863123d769 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/bd82x6x/Makefile.inc M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/ibexpeak/Makefile.inc 4 files changed, 7 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42052/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42052 )
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42052/3/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me.c:
https://review.coreboot.org/c/coreboot/+/42052/3/src/southbridge/intel/bd82x... PS3, Line 112: #ifdef __SIMPLE_DEVICE__ um
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42052
to look at the new patch set (#4).
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
sb/intel/bd82x6x: Drop unneeded files from SMM
We also drop all `__unused` function attributes on these files.
Tested with BUILD_TIMELESS=1, Asus P8Z77-V LX2 remains identical.
Change-Id: I37219bddd2ad9b56711508a3d28056863123d769 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/bd82x6x/Makefile.inc M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/ibexpeak/Makefile.inc 4 files changed, 7 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42052/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42052 )
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42052/3/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me.c:
https://review.coreboot.org/c/coreboot/+/42052/3/src/southbridge/intel/bd82x... PS3, Line 112: #ifdef __SIMPLE_DEVICE__
um
Done
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42052
to look at the new patch set (#6).
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
sb/intel/bd82x6x: Drop unneeded files from SMM
We also drop all `__unused` function attributes on these files.
Tested with BUILD_TIMELESS=1, Asus P8Z77-V LX2 remains identical.
Change-Id: I37219bddd2ad9b56711508a3d28056863123d769 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/bd82x6x/Makefile.inc M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/ibexpeak/Makefile.inc 4 files changed, 7 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42052/6
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42052 )
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42052/3/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me.c:
https://review.coreboot.org/c/coreboot/+/42052/3/src/southbridge/intel/bd82x... PS3, Line 112: #ifdef __SIMPLE_DEVICE__
Done
rebase lost one commit
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42052
to look at the new patch set (#7).
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
sb/intel/bd82x6x: Drop unneeded files from SMM
We also drop all `__unused` function attributes on these files.
Tested with BUILD_TIMELESS=1, Asus P8Z77-V LX2 remains identical.
Change-Id: I37219bddd2ad9b56711508a3d28056863123d769 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/bd82x6x/Makefile.inc M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/ibexpeak/Makefile.inc 4 files changed, 7 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42052/7
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42052 )
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
Patch Set 8: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42052 )
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
Patch Set 8: Code-Review+2
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42052 )
Change subject: sb/intel/bd82x6x: Drop unneeded files from SMM ......................................................................
Abandoned
Superseded
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Rudolph (Code Review)